Project

General

Profile

Actions

Feature #20603

closed

Keep compatibility with Rails 4.1 to support SQL Server < 2012

Added by Etienne Massip over 8 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Rails support
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Wont fix

Description

It would allow Redmine to be compatible with SQL Server 2005 to 2008R2 until Rails 5 makes his way out and 4.1 branch gets unmaintained.

<copy/paste from #14534#note-46 >

As Toshi noticed (Redmine 3.0 problem with MSSQL 2008) they chose to break compatibility with MSSQL < 2012 which is a bit brutal.

Specifying Rails ~> 4.1 in Gemfile seems to do the trick with trunk @ r14520, do you know if some of the changes that were made when switching from 4.1 to 4.2 aren't 4.1 compatible?

</copy/paste>

I don't think there are plans for using Rails 4.2 features, any idea?


Files

test.log.txt (58.5 KB) test.log.txt Toshi MARUYAMA, 2015-09-16 11:49
Actions #1

Updated by Etienne Massip over 8 years ago

  • Description updated (diff)
Actions #2

Updated by Toshi MARUYAMA over 8 years ago

I tried "rake test" on trunk r14589 Ruby 1.9.3 sqlite3 with this change.

diff --git a/Gemfile b/Gemfile
--- a/Gemfile
+++ b/Gemfile
@@ -4,7 +4,8 @@ if Gem::Version.new(Bundler::VERSION) <
   abort "Redmine requires Bundler 1.5.0 or higher (you're using #{Bundler::VERSION}).\nPlease update with 'gem update bundler'." 
 end

-gem "rails", "4.2.4" 
+gem "rails", "~> 4.1.13" 
+gem "loofah" 
 gem "jquery-rails", "~> 3.1.3" 
 gem "coderay", "~> 1.1.0" 
 gem "builder", ">= 3.0.4" 

I got many test failures.
How do you deal?

Actions #3

Updated by Go MAEDA over 2 years ago

  • Status changed from New to Closed
  • Resolution set to Wont fix

The currently active versions of Redmine require Rails 5.2. And ActiveRecord SQL Server Adapter for Rails 5.2 only supports Microsoft SQL Server >= 2012. So, it is impossible to support older versions of MS SQL Server.

Actions

Also available in: Atom PDF