Project

General

Profile

Actions
Copy link

Patch #21434

closed

Additional CSS class for version status

Added by Tobias Fischer over 8 years ago. Updated about 8 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Roadmap
Target version:
3.3.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The version status (open, locked, closed) isn't accessible for theme designers. Neither in Roadmap view nor in Version details view.

This patch adds another CSS class after #19341 in Roadmap view.

Plus it adds the new CSS classes from #19341 and the ones introduced here also in Version details view.
It can be discussed where to place the CSS classes. I put it on <div id="#roadmap"> but I believe it could also be nice to have them available when styling the <h2> heading... More opinions?

Files

Download all files
001_add-version-status-css-class-to-roadmap.diff (743 Bytes) 001_add-version-status-css-class-to-roadmap.diff Tobias Fischer, 2015-12-06 13:49
002_add-version-status-css-class-to-version-details.diff (680 Bytes) 002_add-version-status-css-class-to-version-details.diff Tobias Fischer, 2015-12-06 13:49
Screenshot-of-patch-002.png (77.6 KB) Screenshot-of-patch-002.png Tobias Fischer, 2015-12-06 13:49
Screenshot-of-patch-001.png (87.3 KB) Screenshot-of-patch-001.png Tobias Fischer, 2015-12-06 13:49

Related issues

Related to Redmine - Defect #21433: "version-completed" class is never set when version has no due dateClosedJean-Philippe Lang

Actions
Actions
Copy link
 #1

Updated by Tobias Fischer over 8 years ago

Just for the record: New CSS classes are:

  • version-status-open for open versions
  • version-status-locked for locked versions
  • version-status-closed for closed versions

This information is more useful than "completed/incompleted" from #19341 when trying to add another version icon for locked versions.

Actions
Copy link
 #2

Updated by Jean-Philippe Lang over 8 years ago

Tobias Fischer wrote:

but I believe it could also be nice to have them available when styling the <h2> heading

Sure, can you update your patch?

Actions
Copy link
 #3

Updated by Tobias Fischer over 8 years ago

Jean-Philippe Lang wrote:

Sure, can you update your patch?

Yes. However, I wasn't sure where to add those classes:
  • I assume <body> isn't appropriate as we normally don't have such classes there.
  • I thought about an <article> tag around the whole content in app/views/versions/show.html.erb to match the behaviour from patch #19341
  • or to add those classes to the <div id="content"> wrapper (which seems to be uncommon as well, right?)

Any suggestions?

Actions
Copy link
 #4

Updated by Toshi MARUYAMA over 8 years ago

  • Related to Defect #21433: "version-completed" class is never set when version has no due date added
Actions
Copy link
 #5

Updated by Tobias Fischer about 8 years ago

Any chance to get this in 3.3 together with #21433 and all the other UI/CSS improvements?
The current patch would be okay.

However, if someone answers my question from comment 3 I'm going to update the patch 002 asap.

Actions
Copy link
 #6

Updated by Jean-Philippe Lang about 8 years ago

  • Assignee set to Jean-Philippe Lang
  • Target version set to 3.3.0

I thought about an <article> tag around the whole content in app/views/versions/show.html.erb to match the behaviour from patch #19341

That sounds reasonable.

Actions
Copy link
 #7

Updated by Jean-Philippe Lang about 8 years ago

  • Status changed from New to Closed
Actions
Copy link

Also available in: Atom PDF