Patch #22112
add html5 audio controls if attachment is mp3
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | Attachments | |||
| Target version: | - |
Description
I added a simple line on bottom of application.js to create a HTML5 control if the attachment is an mp3.
i share it with you.
$(document).ready(function(){
$(".attachments p:has(a[href$='.mp3'])").after(function () {
return "<audio controls><source src=\"" +
$(this).find(" a[href$='.mp3'] ").attr("href")+"\" type=\"audio/mpeg\"</audio>"
});
});
Related issues
History
#1
Updated by Toshi MARUYAMA about 3 years ago
- Description updated (diff)
#2
Updated by Toshi MARUYAMA about 3 years ago
- Description updated (diff)
#3
Updated by diamond2nv GitHub about 2 years ago
- File application.zip added
Thank for Toshi MARUYAMA having added a simple line on bottom of application.js to create a HTML5 control if the attachment is an mp3.
Add little change for both <video>(.mp4) and <audio>(.mp3) support, just refresh your browser and see after the new js!
$(document).ready(function(){
$(".attachments p:has(a[href$='.mp3'])").after(function () {
return "<audio controls><source src=\"" +
$(this).find(" a[href$='.mp3'] ").attr("href")+"\" type=\"audio/mp3\"</audio>"
});
});
$(document).ready(function(){
$(".attachments p:has(a[href$='.mp4'])").after(function () {
return "<video width=\"600\" height=\"400\" controls><source src=\"" +
$(this).find(" a[href$='.mp4'] ").attr("href")+"\" type=\"video/mp4\"</video>"
});
});
#4
Updated by diamond2nv GitHub about 2 years ago
return "<video width=\"600\" height=\"400\" controls><source src=\"" +
640*360?
Not fit for android browser
#5
Updated by Toshi MARUYAMA about 2 years ago
- Related to Feature #10138: Video Player added
#6
Updated by Go MAEDA over 1 year ago
- Related to Patch #27336: Render previews for audio and video files added