Project

General

Profile

Actions

Patch #236

closed

Patch for remote cvs server and non-English cvs environment

Added by Choi Jong Yoon over 16 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Hello.
I made a patch for cvs_adapter.rb

1. patch for remote cvs server
We installed Redmine to a server and this is not a cvs repository server.
so the cvsroot value is like below
:pserver::/home/cvsroot
so we should slice string before '/' in the line 145 of cvs_adapter.rb

this is not obliged to a user for local cvs repository, but is useful for user like me. :-)

2. patch for non-English User
When I want to insert the revision data to MySQL database, I should encode the non-English commit message to UTF-8.
This may be the problem of my environment(Korean), so please check the code !!

Thank you for reading.


Files

patch.txt (1.24 KB) patch.txt Choi Jong Yoon, 2008-02-03 11:01

Related issues

Related to Redmine - Defect #3196: Don't properly support encoding of repositories (git)ClosedToshi MARUYAMA2009-04-17

Actions
Related to Redmine - Defect #2890: CVS fetch changesets for latin1 charsetClosed2009-03-03

Actions
Actions #1

Updated by Jean-Philippe Lang over 16 years ago

Hi,

Concerning 1, I used a different approach (the patch doesn't
work for a local CVS on windows).
I've tested it with a remove CVS, it now works fine as well.

Concerning 2, Setting.repositories_encodings can contain more
than encoding (comma separated). In this case, the patch doesn't
work as only one should be given to iconv.
I'll try to fix it later.

Thanks for the feedback.

Regards

Actions #2

Updated by Toshi MARUYAMA over 13 years ago

  • Category set to SCM
Actions #3

Updated by Toshi MARUYAMA about 13 years ago

  • Status changed from New to Closed

I added feature #1735 until r4983.

Actions

Also available in: Atom PDF