Project

General

Profile

Actions
Copy link

Defect #26393

closed

Error when unchecking all settings on some plugins configurations

Added by Keith Dickmann almost 7 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Jean-Philippe Lang
Category:
Administration
Target version:
3.4.2
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
3.4.1

Description

To Reproduce
1 - install a plugin that only as checkboxes on it settings page (or use uploaded test plugin)
2 - check everything and save
3 - uncheck everything and save
4 - crash

NoMethodError (undefined method `permit!' for nil:NilClass):
app/controllers/settings_controller.rb:70:in `plugin'
lib/redmine/sudo_mode.rb:63:in `sudo_mode'

Files

test_plugin.tar.gz (1.11 KB) test_plugin.tar.gz Keith Dickmann, 2017-07-10 05:46
Actions
Copy link
 #1

Updated by Toshi MARUYAMA almost 7 years ago

  • Status changed from New to Confirmed
  • Target version set to 3.4.2
Actions
Copy link
 #2

Updated by Toshi MARUYAMA almost 7 years ago

It works on Redmine 3.2 and 3.3.

Actions
Copy link
 #3

Updated by Jean-Philippe Lang almost 7 years ago

  • Subject changed from Plugin settings page exception if uncheck all with checkbox only settings to Error when unchecking all settings on some plugins configurations
  • Category set to Administration
  • Status changed from Confirmed to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Fixed in r16812, thanks for pointing this out.

Actions
Copy link
 #4

Updated by Jean-Philippe Lang almost 7 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF