Defect #2707
closedTimeLog adds a new log instead of update on Edit
0%
Description
When you edit a time log, a new time log is produced instead of edited.
In
In http://www.redmine.org/repositories/changes/redmine/trunk/app/views/timelog/edit.rhtml
This:
<% labelled_tabular_form_for :time_entry, @time_entry, :url => {:action => 'edit', :project_id => @time_entry.project} do |f| >
Should be:
< labelled_tabular_form_for :time_entry, @time_entry, :url => {:action => 'edit', :id => @time_entry, :project_id => @time_entry.project} do |f| %>
Many thanks,
Mario
p.s. can I be a contributor, or is there a way already?
Files
Updated by Eric Davis over 16 years ago
- Category set to Time tracking
- Assignee set to Eric Davis
- Affected version (unused) set to devel
Updated by Eric Davis over 16 years ago
- File 0001-Fixed-the-TimeLog-form-it-was-always-posting-to-the.patch 0001-Fixed-the-TimeLog-form-it-was-always-posting-to-the.patch added
- Status changed from New to Resolved
- Assignee changed from Eric Davis to Jean-Philippe Lang
Nice, looks like Jean-Philippe commited right before I did with r2434.
I took a different approach through: instead of adding the TimeEntry id, I make the new TimeEntry route only accept get
requests (REST standard) and make the form send post
requests. I've attached a patch to illustrate.
Which way would be better?
Updated by Jean-Philippe Lang over 15 years ago
- Status changed from Resolved to Closed
- Resolution set to Fixed