Project

General

Profile

Actions

Defect #2764

closed

Test failures in AccountControllerTest

Added by Eric Davis about 15 years ago. Updated about 15 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
-
Target version:
-
Start date:
2009-02-17
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

I tried to debug this but I ran out of time. Running the functional tests for teh AccountController is intermitmently producing test failures. I tracked it down to Setting.openid? not returning true even if it's set to true by a test. The test database might need to be purged to reproduce.

This was caught by my CI server at r2472.

RAILS_ENV=test rake db:test:purge && RAILS_ENV=test rake db:migrate &&  ruby test/functional/account_controller_test.rb
  1) Failure:
test_login_with_openid_for_existing_user(AccountControllerTest)
    [test/functional/account_controller_test.rb:80:in `test_login_with_openid_for_existing_user'
     /home/edavis/dev/redmine/redmine-core/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `__send__'
     /home/edavis/dev/redmine/redmine-core/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `run']:
Expected response to be a <:redirect>, but was <200>

  2) Failure:
test_login_with_openid_with_new_user_and_self_registration_off(AccountControllerTest)
    [test/functional/account_controller_test.rb:98:in `test_login_with_openid_with_new_user_and_self_registration_off'
     /home/edavis/dev/redmine/redmine-core/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `__send__'
     /home/edavis/dev/redmine/redmine-core/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `run']:
Expected response to be a <:redirect>, but was <200>

  3) Failure:
test_login_with_openid_with_new_user_created(AccountControllerTest)
    [test/functional/account_controller_test.rb:87:in `test_login_with_openid_with_new_user_created'
     /home/edavis/dev/redmine/redmine-core/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `__send__'
     /home/edavis/dev/redmine/redmine-core/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `run']:
Expected response to be a <:redirect>, but was <200>

  4) Failure:
test_login_with_openid_with_new_user_created_with_email_activation_should_have_a_token(AccountControllerTest)
    [test/functional/account_controller_test.rb:107:in `test_login_with_openid_with_new_user_created_with_email_activation_should_have_a_token'
     /home/edavis/dev/redmine/redmine-core/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `__send__'
     /home/edavis/dev/redmine/redmine-core/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `run']:
Expected response to be a <:redirect>, but was <200>

  5) Failure:
test_login_with_openid_with_new_user_created_with_manual_activation(AccountControllerTest)
    [test/functional/account_controller_test.rb:119:in `test_login_with_openid_with_new_user_created_with_manual_activation'
     /home/edavis/dev/redmine/redmine-core/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `__send__'
     /home/edavis/dev/redmine/redmine-core/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `run']:
Expected response to be a <:redirect>, but was <200>

  6) Failure:
test_login_with_openid_with_new_user_with_conflict_should_register(AccountControllerTest)
    [test/functional/account_controller_test.rb:134:in `test_login_with_openid_with_new_user_with_conflict_should_register'
     /home/edavis/dev/redmine/redmine-core/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `__send__'
     /home/edavis/dev/redmine/redmine-core/vendor/rails/activerecord/lib/../../activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in `run']:
expecting <"register"> but rendering with <"login">

14 tests, 29 assertions, 6 failures, 0 errors
Actions #1

Updated by Jean-Philippe Lang about 15 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

It should be fixed by r2481.

Actions #2

Updated by Eric Davis about 15 years ago

Looks like that fixed it, CruiseControl and my local system are both reporting all green now. I must have missed Setting#openid? being defined directly, I thought it was using the dynamic class_eval.

Actions

Also available in: Atom PDF