Project

General

Profile

Actions
Copy link

Defect #27790

closed

mercurial: error of double quotes in branch and tag names

Added by Alexander Ryabinovskiy almost 6 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:
4.2.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Hello.
I have redmine 3.4.3 installation.
Redmine can`t handle mercurial branches with double quotes, it throws an error after parsing with ActiveSupport::XmlMini.parse(xml):

hg: error during getting info: undefined method `[]' for nil:NilClass

because "xml" variable contains string like this:
<branch revision=\"138\" node=\"8a17814e772e4a41b9c2480e047dce7d9181a39e\" name=\"\"TestBranch\"\"/>

My solution is to replace double quotes in branch name with 

&quot;
in redminehelper.py, .patch is in attach.

Files

redmine_redminehelper_fix.diff (968 Bytes) redmine_redminehelper_fix.diff Alexander Ryabinovskiy, 2017-12-13 11:55
Actions
Copy link
 #1

Updated by Toshi MARUYAMA over 3 years ago

  • Tracker changed from Patch to Defect
  • Subject changed from mercurial - fix double quotes in branch names to mercurial: error of double quotes in branch and tag names
  • Status changed from New to Closed
  • Target version set to 4.2.0
  • Resolution set to Fixed

Fixed by r19765.

Actions
Copy link

Also available in: Atom PDF