Defect #27884

Support RTL Bidirection text

Added by Hooman Valibeigi 15 days ago. Updated 1 day ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Text formatting
Target version:3.4.5
Resolution: Affected version:3.4.2

Description

The fix at #8121 is broken as stated in my last comment there.

My environment: Redmine 3.4.2, Google Chrome 63

1. `p(rtl).` maps to `class="wiki-class-rtl"` in html, but there is no such class in application.css
2. `unicode-bidi:bidi-override` must be removed or set to `normal`
See https://www.w3schools.com/cssref/pr_text_unicode-bidi.asp

History

#1 Updated by Toshi MARUYAMA 4 days ago

  • Target version set to 3.4.5

Hooman Valibeigi wrote:

The fix at #8121 is broken as stated in my last comment there.

My environment: Redmine 3.4.2, Google Chrome 63

1. `p(rtl).` maps to `class="wiki-class-rtl"` in html, but there is no such class in application.css

I think we can change like r16503.

2. `unicode-bidi:bidi-override` must be removed or set to `normal`
See https://www.w3schools.com/cssref/pr_text_unicode-bidi.asp

Which do you think is better?

#2 Updated by Hooman Valibeigi 1 day ago

Toshi MARUYAMA wrote:

Which do you think is better?

Replacing the following lines in application.xml

.ltr {direction:ltr !important; unicode-bidi:bidi-override;}
.rtl {direction:rtl !important; unicode-bidi:bidi-override;}

with these, will fix it
.wiki-class-ltr {direction:ltr !important;}
.wiki-class-rtl {direction:rtl !important;}

#3 Updated by Hooman Valibeigi 1 day ago

It would be more appreciated if someone documents the syntax of `p(rtl).` on the wiki
https://www.redmine.org/projects/redmine/wiki/RedmineTextFormattingTextile

#4 Updated by Toshi MARUYAMA 1 day ago

Hooman Valibeigi wrote:

Toshi MARUYAMA wrote:

Which do you think is better?

Replacing the following lines in application.xml

Do you mean application.css, not application.xml?

#5 Updated by Hooman Valibeigi 1 day ago

Toshi MARUYAMA wrote:

Do you mean application.css, not application.xml?

Yes, redmine/public/stylesheets/application.css

Also available in: Atom PDF