Project

General

Profile

Actions

Feature #2803

closed

Support for Javascript in Themes

Added by Leonard Brünings about 15 years ago. Updated about 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Themes
Target version:
Start date:
2009-02-21
Due date:
% Done:

0%

Estimated time:
0.50 h
Resolution:
Fixed

Description

Our theme requires Javascript and it seems the only way to include js is via a custom plugin,
which is a bit overkill IMHO.

Someone already wrote a patch http://www.redmine.org/issues/show/1864 so the work to implement
this in the trunk should be limited.


Related issues

Related to Redmine - Patch #1864: Automatically extend /public with javascripts and images from a theme folderClosed2008-09-05

Actions
Actions #1

Updated by Ruben Kruiswijk about 13 years ago

What is the status about this issue? I think it would be very valuable to add javascript support on themes. Are there problems in integrating the patch in issue #1864 ?

Actions #2

Updated by Jean-Philippe Lang about 13 years ago

Unlike CSS, I don't think it makes sense to let themes override the core application.js (any change to that file would break the compatibility with the theme). Instead, we could automatically load a given script (/javascripts/theme.js for example) if it is found in the theme directory.

Actions #3

Updated by Leonard Brünings about 13 years ago

That solution would be fine.

Actions #4

Updated by Ruben Kruiswijk about 13 years ago

That solution would be fine for me too. Could that feature be implemented in Redmine 1.0.5?

Actions #5

Updated by Jean-Philippe Lang about 13 years ago

  • Category set to Themes
  • Target version set to 1.1.0

No features in stable branches but I think I can add this improvement to 1.1.

Actions #6

Updated by Jean-Philippe Lang about 13 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

Feature added in r4558.
Add javascripts/theme.js to your theme directory and it will loaded automatically.

Actions

Also available in: Atom PDF