Patch #30433

Flash notices to behave like flash notices :)

Added by Anonymous over 3 years ago. Updated over 3 years ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:-

Description

This is a patch which will add one way animation for flash notices, so they will now slide, wait for some time, and then slide out :)

flash-notice-animation.diff Magnifier (1.39 KB) Anonymous, 2019-01-15 09:49

flash-notice-animation-success-only-ie11compatible.patch Magnifier (885 Bytes) Anonymous, 2019-01-29 10:48

History

#1 Updated by Marius BALTEANU over 3 years ago

It is an interesting feature, but maybe it should be applied only for success notifications because in the case of error notifications, some users (including myself) prefer to have the message on the screen for a longer time. An use case is when you bulk edit issues and you have errors for some issues and you will use the error message to resolve each issue one at a time.

Anyway, a feature related to this one is to add the possibility to close/hide the notification messages.

#2 Updated by Anonymous over 3 years ago

The animation length can also be expanded by changing time in the place where it's called in animation: slideFlash 3s ease-in-out forwards; line and if we only want success messages to animate like that, then we can just move the animation call from a more global div.flash container to a div.flash.notice which represents only success messages. :)

Then there are also div.flash.warning and div.flash.error classes.
Maybe we could also just define different animation length for each of them, else if we want them to remain static, we can just skip adding any animation calls to them.

#3 Updated by Anonymous over 3 years ago

Made improvements to this:
1. Now only animates on success notifications.
2. I made animation code more compact, because now animation will only do the collapse animation, so notification will appear as before, only it will collapse after 3 seconds, I also thought it's better like that, since it also moves #main container and it will be less annoying when done only once, which is now on it's collapsing.
3. I did minor tricks to make it work in IE11 like everywhere else.

previous patch must be reverted.

Also available in: Atom PDF