Patch #31034

Remove encoding magic comments

Added by Go MAEDA 4 months ago. Updated 4 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Code cleanup/refactoring
Target version:4.1.0

Description

The magic comment "encoding: utf-8" is no longer necessary. It was necessary only in Ruby 1.9 in which default script encoding was ASCII-8BIT. The default is UTF-8 after Ruby 2.0.

Since Redmine 4.0 or later don't support Ruby 1.9 (#25538), we can remove the magic comment.

remove-magic-comment.patch Magnifier (25 KB) Go MAEDA, 2019-03-16 06:19

Associated revisions

Revision 17976
Added by Go MAEDA 4 months ago

Remove unnecessary encoding magic comment (#31034).

The default script encoding is UTF-8 in Ruby 2.0 or later.

Patch by Go MAEDA.

History

#1 Updated by Go MAEDA 4 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed.

#2 Updated by Go MAEDA 4 months ago

  • Tracker changed from Defect to Patch

#3 Updated by Go MAEDA 4 months ago

  • Subject changed from Remove the encoding magic comment to Remove encoding magic comments

Also available in: Atom PDF