Defect #31268

Fix gaps in resizable gantt chart

Added by Go MAEDA 3 months ago. Updated 3 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Gantt
Target version:4.0.4
Resolution:Fixed Affected version:

Description

See #20481#note-20.

[Before]

[After]

0001-Fix-gaps-in-resizable-gantt-chart.patch Magnifier (1.81 KB) Felix Gliesche, 2019-04-29 11:47


Related issues

Related to Redmine - Feature #20481: Gantt: right and left resizable panel Closed

Associated revisions

Revision 18089
Added by Go MAEDA 3 months ago

Fix gaps in resizable gantt chart (#31268).

Patch by Felix Gliesche.

Revision 18090
Added by Go MAEDA 3 months ago

Merged r18089 from trunk to 4.0-stable (#31268).

Revision 18095
Added by Go MAEDA 3 months ago

Fix that r18089 disabled context menu in the gantt subject column (#31268).

Patch by Felix Gliesche.

Revision 18096
Added by Go MAEDA 3 months ago

Merged r18095 from trunk to 4.0-stable (#31268).

History

#1 Updated by Go MAEDA 3 months ago

  • Related to Feature #20481: Gantt: right and left resizable panel added

#2 Updated by Go MAEDA 3 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix. Thank you.

#3 Updated by Go MAEDA 3 months ago

  • Status changed from Closed to Resolved

The right-click context menu (#10485) is broken after applying the patch. the context menu does not open when you click a subject of issues.

After my investigation, I found that removing "z-index:1" from show.html.erb resolves the issue.

Felix Gliesche, do we really need the "z-index: 1"?

Index: app/views/gantts/show.html.erb
===================================================================
--- app/views/gantts/show.html.erb    (リビジョン 18090)
+++ app/views/gantts/show.html.erb    (作業コピー)
@@ -144,7 +144,6 @@
     <%= content_tag(:div, "", :style => style, :class => "gantt_hdr") %>
     <%
       style  = "" 
-      style += "z-index: 1;" 
       style += "width: #{subject_width}px;" 
       style += "height: #{t_height}px;" 
       style += 'border-left: 1px solid #c0c0c0;'

#4 Updated by Go MAEDA 3 months ago

  • Status changed from Resolved to Reopened

#5 Updated by Felix Gliesche 3 months ago

Thanks GO MAEDA for letting me know. I'll take care of it.

#6 Updated by Felix Gliesche 3 months ago

Dear GO MAEDA,

attached you'll find the updated patch, initially uploaded to #20481.

#7 Updated by Go MAEDA 3 months ago

  • Status changed from Reopened to Closed

Felix Gliesche wrote:

Dear GO MAEDA,

attached you'll find the updated patch, initially uploaded to #20481.

Committed the fix. Thank you for updating the patch so quickly.

Also available in: Atom PDF