Patch #31343

Visually distinguishable style for code tag

Added by Go MAEDA 9 days ago. Updated 4 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI
Target version:4.1.0

Description

I propose to make the style for code tag more distinguishable.

Currently, the font-family property is the only property which is set for code tag. So, it is a bit difficult to distinguish text enclosed in code tag.

It will be easily distinguishable if we set background color for them. It is so common. You can see examples on many sites such as GitHub and https://bugs.ruby-lang.org/.

[Before]

[After]

code-style-before@2x.png (67.1 KB) Go MAEDA, 2019-05-11 12:04

code-style-after@2x.png (68.8 KB) Go MAEDA, 2019-05-11 12:04

style-for-code.diff Magnifier (474 Bytes) Go MAEDA, 2019-05-11 12:04

style-for-code-v2.diff Magnifier (483 Bytes) Go MAEDA, 2019-05-13 16:34

style-for-code-v3.diff Magnifier (498 Bytes) Go MAEDA, 2019-05-15 10:13

Associated revisions

Revision 18170
Added by Go MAEDA 4 days ago

Visually distinguishable style for inline code (#31343).

Patch by Go MAEDA.

History

#1 Updated by Go MAEDA 7 days ago

  • Subject changed from Visually distinguishable code tag style to Visually distinguishable style for code tag
  • Target version set to 4.1.0

Setting the target version to 4.1.0.

#2 Updated by Go MAEDA 7 days ago

#3 Updated by Go MAEDA 5 days ago

Update the patch.

  • Changed the color to rgba(62, 91, 118, 0.08). The previous color rgba(0, 102, 187, 0.05) looks like selected text in some operating system
  • Fixed wrong selector
  • Fixed that the style is not applied in long text custom fields

#4 Updated by Go MAEDA 4 days ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch.

Also available in: Atom PDF