Defect #31503

Undefined local variable sender_email in MailHandler#receive_message_reply

Added by Andriy Lesyuk about 1 month ago. Updated about 1 month ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Email receiving
Target version:3.4.11
Resolution:Fixed Affected version:3.4.10

Description

When receiving a reply to a locked topic, mail handler crashes with the following error:

  undefined local variable or method `sender_email' for #<MailHandler:0x0055675dfa9e10>
Did you mean?  send_action
  app/models/mail_handler.rb:289:in `receive_message_reply'

That's because receive_message_reply is trying to use sender_email variable, which was not defined in this method.
Here is the corresponding line (source:trunk/app/models/mail_handler.rb@18198#L277):

logger&.info "MailHandler: ignoring reply from [#{sender_email}] to a locked topic" 

fix-31503-trunk.diff Magnifier - patch for the trunk (1.22 KB) Go MAEDA, 2019-06-09 14:07

fix-31503-3_4.diff Magnifier - patch for 3.4-stable and 4.0-stable (1.21 KB) Go MAEDA, 2019-06-09 14:07

Associated revisions

Revision 18239
Added by Go MAEDA about 1 month ago

Fix "Undefined local variable sender_email" error in MailHandler#receive_message_reply when receiving a reply to a locked topic (#31503).

Patch by Go MAEDA.

Revision 18240
Added by Go MAEDA about 1 month ago

Backport the fix r18239 to 4.0-stable (#31503).

Revision 18241
Added by Go MAEDA about 1 month ago

Backport the fix r18239 to 3.4-stable (#31503).

History

#1 Updated by Go MAEDA about 1 month ago

Attaching patches to fix the issue.

#2 Updated by Go MAEDA about 1 month ago

  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch to the trunk. Thank you for reporting this issue.

#3 Updated by Go MAEDA about 1 month ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF