Project

General

Profile

Actions

Patch #32924

closed

tmp/pdf directory is no longer necessary

Added by Go MAEDA about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

We can remove the following code because tmp/pdf directory that is used when generating pdf files is no longer used after r13358.

Curentry, the PDF library rbpdf uses tmp instead of tmp/pdf as a temporary directory.

diff --git a/lib/redmine/export/pdf.rb b/lib/redmine/export/pdf.rb
index 85beb8bdb..e43459b08 100644
--- a/lib/redmine/export/pdf.rb
+++ b/lib/redmine/export/pdf.rb
@@ -28,8 +28,6 @@ module Redmine
         attr_accessor :footer_date

         def initialize(lang, orientation='P')
-          @@k_path_cache = Rails.root.join('tmp', 'pdf')
-          FileUtils.mkdir_p @@k_path_cache unless File::exist?(@@k_path_cache)
           set_language_if_valid lang
           super(orientation, 'mm', 'A4')
           set_print_header(false)

Files


Related issues

Related to Redmine - Defect #12189: Missing tmp/pdf directoryClosed

Actions
Actions #1

Updated by Go MAEDA about 4 years ago

Actions #2

Updated by Go MAEDA about 4 years ago

  • Target version set to 4.2.0

Setting the target version to 4.2.0.

Actions #3

Updated by Go MAEDA about 4 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch.

Actions #4

Updated by Go MAEDA about 4 years ago

  • Subject changed from Creating tmp/pdf directory is no longer necessary to tmp/pdf directory is no longer necessary
Actions

Also available in: Atom PDF