Defect #33186

field_activity should be used rather than label_activity in the context of time tracking

Added by Go MAEDA 7 months ago. Updated 7 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:I18n
Target version:4.2.0
Resolution:Fixed Affected version:

Description

Redmine has two i18n labels for the word "Activity", label_activity and field_activity. Of them, field_activity is used in the context of time tracking.

However, in some places, label_activity is incorrectly used in the context of time tracking. This causes inconsistent screen display such as Japanese, Korean, Russian because those languages assigns different translations for label_activity and field_activity as follows:

$ egrep '(label|field)_activity' config/locales/ja.yml
  field_activity: 作業分類
  label_activity: 活動
$ egrep '(label|field)_activity' config/locales/ko.yml
  field_activity: 작업종류
  label_activity: 작업내역
$ egrep '(label|field)_activity' config/locales/ru.yml
  field_activity: Деятельность
  label_activity: Действия

The attached patch replaces label_activity used in the context of the time tracking with field_activity.

use-field_activity.patch Magnifier (1.37 KB) Go MAEDA, 2020-03-23 15:37

field_activity-and-label_activity@2x.png (155 KB) Go MAEDA, 2020-03-23 15:41

Associated revisions

Revision 19619
Added by Go MAEDA 7 months ago

Use field_activity rather than label_activity in the context of time tracking (#33186).

Patch by Go MAEDA.

History

#1 Updated by Go MAEDA 7 months ago

  • Target version set to 4.2.0

Setting the target version to 4.2.0.

#2 Updated by Go MAEDA 7 months ago

  • Subject changed from label_activity is incorrectly used instead of field_activity in the context of time tracking to field_activity should be used rather than label_activity in the context of time tracking
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch.

Also available in: Atom PDF