Defect #33357

rendering extra "--" footer of git patch attachment

Added by Toshi MARUYAMA 4 months ago. Updated 3 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Attachments
Target version:4.2.0
Resolution:Fixed Affected version:

Description

From #17809.

For example #4511 0002-Use-Principal-to-get-users-and-groups-for-watchers-i.patch.

#17809#note-5 has solution.

git-diff.png (120 KB) Toshi MARUYAMA, 2020-04-26 17:01

Associated revisions

Revision 19734
Added by Toshi MARUYAMA 4 months ago

add test to UnifiedDiffTest to keep similar git footer line (#33357)

Revision 19751
Added by Toshi MARUYAMA 3 months ago

add git format patch to UnifiedDiffTest (#33357)

Revision 19752
Added by Toshi MARUYAMA 3 months ago

remove git format patch footer (#33357)

History

#1 Updated by Toshi MARUYAMA 4 months ago

  • Subject changed from rendering extra "---" header and "--" footer of git patch attachment to rendering extra "--" footer of git patch attachment

Fixed title.

#2 Updated by Toshi MARUYAMA 4 months ago

#17809#note-5 is not solution in this case.

# test
# test
# next line has white space after '-'
- 
-
# test
# test
# test
# test
diff --git a/test.rb b/test.rb
--- a/test.rb
+++ b/test.rb
@@ -3,9 +3,6 @@

 # test
 # test
-# next line has white space after '-'
-- 
--
 # test
 # test
 # test

#3 Updated by Toshi MARUYAMA 3 months ago

  • Target version set to 4.2.0
  • Resolution set to Fixed

Fixed by r19752.

Also available in: Atom PDF