Project

General

Profile

Actions

Defect #33926

closed

Rake tasks "db:encrypt" and "db:decrypt" may fail due to validation error

Added by Go MAEDA over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Accounts / authentication
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

encrypt_all and decrypt_all methods in lib/redmine/ciphering.rb are expected to skip validation when saving an object. But they don't because of typo in parameter name.

It may cause a failure to run rake db:encrypt or rake db:decrypt. You can reproduce it by running the following commands.

$ bin/rake db:fixtures:load
$ bin/rake db:encrypt
rake aborted!
Some objects could not be saved after encryption, update was rolled back.

Here is a fix:

diff --git a/lib/redmine/ciphering.rb b/lib/redmine/ciphering.rb
index d5ceb0c6c..469d3b9e6 100644
--- a/lib/redmine/ciphering.rb
+++ b/lib/redmine/ciphering.rb
@@ -74,7 +74,7 @@ module Redmine
           all.each do |object|
             clear = object.send(attribute)
             object.send "#{attribute}=", clear
-            raise(ActiveRecord::Rollback) unless object.save(:validation => false)
+            raise(ActiveRecord::Rollback) unless object.save(validate: false)
           end
         end ? true : false
       end
@@ -84,7 +84,7 @@ module Redmine
           all.each do |object|
             clear = object.send(attribute)
             object.send :write_attribute, attribute, clear
-            raise(ActiveRecord::Rollback) unless object.save(:validation => false)
+            raise(ActiveRecord::Rollback) unless object.save(validate: false)
           end
         end ? true : false
       end

Files

33926.patch (1.86 KB) 33926.patch Go MAEDA, 2020-08-30 15:02
Actions #1

Updated by Go MAEDA over 3 years ago

  • Subject changed from Validation is not skipped due to typo when running db:encrypt/db:decrypt rake tasks to "rake db:encrypt" / "rake db:decrypt" may fail due to validation error
Actions #2

Updated by Go MAEDA over 3 years ago

Added test code.

Actions #3

Updated by Go MAEDA over 3 years ago

  • Target version set to 4.0.8

Setting the target version to 4.0.8.

Actions #4

Updated by Go MAEDA over 3 years ago

  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch.

Actions #5

Updated by Go MAEDA over 3 years ago

  • Subject changed from "rake db:encrypt" / "rake db:decrypt" may fail due to validation error to Rake tasks "db:encrypt" and "db:decrypt" may fail due to validation error
Actions #6

Updated by Go MAEDA over 3 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF