Patch #3437

Textile parser regression with !! url

Added by Vianney Lecroart over 13 years ago. Updated over 11 years ago.

Status:NewStart date:2009-06-02
Priority:NormalDue date:
Assignee:-% Done:


Category:Text formatting
Target version:-


In #3209 you added support for excalamation marks in url but it disabled the possibility to do linkable image.

Suggested patch:

When we arrive at evaluating this re, the input looks like either like:

<p>!/attachments/download/1!</p> <-- we want to expand 
<p>!lol! <-- we don't want to expand

But also like, when we have "p=."

<p :redsh#1:>!/attachments/download/1!</p>

Therefore I suggest to use this re in redcloth3.rb :

    IMAGE_RE = /
            (<p>|<p\s:.*:>|\s|^) # start of line?
            \!                   # opening


#1 Updated by Toshi MARUYAMA over 11 years ago

  • Category set to Text formatting

Also available in: Atom PDF