Project

General

Profile

Actions

Patch #34969

closed

Remove dependency on MimeMagic

Added by Go MAEDA about 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Gems support
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In Redmine, MimeMagic is used to check that files with invalid formats are not passed to ImageMagick when generating thumbnail images with ImageMagick.

This patch replaces MimeMagic with Marcel, a gem bundled with Rails. The benefits of this change are as follows:

  • Simplifies the installation process: Due to a licensing issue, the MIME database freedesktop.org.xml was removed from MimeMagic. As a result, you have to make sure that your system has shared-mime-info before you install Redmine. Marcel bundles another database Apache Tika, so you don't have to install MIME database separately
  • Can reduce memory usage: By replacing MimeMagic with Marcel, we can reduce one gem dependency. Rails used to depend on MimeMagic, but in Rails 5.2.5 it no longer does. Now only Redmine itself depends on MimeMagic

Files


Related issues

Related to Redmine - Patch #34966: Update Rails to 5.2.5Closed

Actions
Actions #1

Updated by Go MAEDA about 3 years ago

Actions #2

Updated by Go MAEDA about 3 years ago

  • Target version set to 4.2.0
Actions #3

Updated by Go MAEDA about 3 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patches.

Actions #4

Updated by Go MAEDA about 3 years ago

  • Status changed from Closed to Reopened
  • Target version changed from 4.2.0 to 4.1.3

I think it is better to merge the change to older versions for the following reason. Keep using MimeMagic may cause installation trouble in some environments.

Go MAEDA wrote:

  • Simplifies the installation process: Due to a licensing issue, the MIME database freedesktop.org.xml was removed from MimeMagic. As a result, you have to make sure that your system has shared-mime-info before you install Redmine. Marcel bundles another database Apache Tika, so you don't have to install MIME database separately
Actions #5

Updated by Go MAEDA about 3 years ago

  • Status changed from Reopened to Closed

Backported to 4.1-stable in r20877 and r20878.

Actions #6

Updated by Go MAEDA almost 3 years ago

  • Status changed from Closed to Reopened
  • Target version changed from 4.1.3 to 4.0.9
Actions #8

Updated by Go MAEDA almost 3 years ago

  • Status changed from Reopened to Closed

Backported to 4.0-stable in r20953.

Actions

Also available in: Atom PDF