Actions
Defect #3779
closed
The requesting revision isn't the revision who is display in some cases
Start date:
2009-08-25
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
This issue occur since r2840.
For example : when you want viewing revision 3 and in your repository you have 40 revisions or more, the revision 39 appears and if you have 400 revisions or more, the revision 399 appears ...
This issue is due to the new query who search a revision with the begin of his non-numeric hash.
Check my patch to resolve this bug.
Files
Updated by Babar O'Cap over 14 years ago
- File repository_find_revision_by_numeric_changeset_or_non-numeric_hash_v2.patch repository_find_revision_by_numeric_changeset_or_non-numeric_hash_v2.patch added
Tidying up my patch
Updated by Eric Davis over 14 years ago
I'd prefer not rescuing nil, it can coverup exceptions that should be raised. What if you rescue the specific error from Integer and handle it by using the non-numeric find?
Updated by Babar O'Cap over 14 years ago
- File repository_find_revision_by_numeric_changeset_or_non-numeric_hash_v3.patch repository_find_revision_by_numeric_changeset_or_non-numeric_hash_v3.patch added
Here a new version of my patch for rescuing revision with the non-numeric find.
Updated by Jean-Philippe Lang over 14 years ago
- Status changed from New to Closed
- Resolution set to Fixed
Fixed in r2898.
Thanks for pointing this out.
Actions