Defect #3951
The SubversionAdapter entries function should use io.readlines instead of io.read
| Status: | New | Start date: | 2009-09-30 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | SCM | Estimated time: | 1.00 hour | |
| Target version: | - | |||
| Resolution: | Affected version: | 0.8.4 |
Description
The SubversionAdapter entries function should use io.readlines instead of io.read. It has the potential to proceed with a partial document.
History
#1
Updated by Jean-Philippe Lang over 12 years ago
What is the problem with io.read ?
#2
Updated by Brandon Enochs over 12 years ago
Jean-Philippe Lang wrote:
What is the problem with io.read ?
io.read doesn't wait until the process was finished. We had an SVN server that we were communication with over a slow connection. As a result, io.read would only return a small portion of the SVN entries before trying to parse the XML file.
#3
Updated by Singyu Jo over 12 years ago
Brandon Enochs wrote:
Jean-Philippe Lang wrote:
What is the problem with io.read ?
io.read doesn't wait until the process was finished. We had an SVN server that we were communication with over a slow connection. As a result, io.read would only return a small portion of the SVN entries before trying to parse the XML file.
io.readline and io.readlines have the same problem.
It reads only small portion.
#4
Updated by Brandon Enochs over 12 years ago
Really? Using io.readlines fixed our problem of io.read not waiting until the process had finished.
#5
Updated by Singyu Jo over 12 years ago
I think IO.popen() doesn't work WELL on Windows 2003.
see this: http://rubyforge.org/tracker/?func=detail&atid=1698&aid=2672&group_id=426