Defect #3979
bad strings in notification messages
Status: | Closed | Start date: | 2009-10-06 | |
---|---|---|---|---|
Priority: | Normal | Due date: | ||
Assignee: | % Done: | 0% | ||
Category: | Translations | |||
Target version: | - | |||
Resolution: | Fixed | Affected version: |
Description
When a file is added to or deleted from an issue, issues_helper.rb
builds (part of) notification message by the following code block:
case detail.property when 'attr', 'cf' if !detail.old_value.blank? l(:text_journal_changed, :label => label, :old => old_value, :new => value) else l(:text_journal_set_to, :label => label, :value => value) end when 'attachment' "#{label} #{value} #{l(:label_added)}" end else case detail.property when 'attr', 'cf' l(:text_journal_deleted, :label => label, :old => old_value) when 'attachment' "#{label} #{old_value} #{l(:label_deleted)}" end end
String composition like "#{label} #{value} #{l(:label_added)}"
is not valid for non-english locales. The string template should be translated in a whole.
Associated revisions
History
#1
Updated by Jean-Philippe Lang over 12 years ago
- Status changed from New to Closed
- Resolution set to Fixed
Strings fixed in r2907.