Defect #4186

Diff view shows two tables and partial diff

Added by Sjoerd Langke almost 12 years ago. Updated almost 12 years ago.

Status:ClosedStart date:2009-11-09
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:0.9.0
Resolution:Fixed Affected version:0.8.6

Description

In attached screenshot, you see the diff view with two tables. I expect only one table, because I view the diff of only one file.

Furthermore, the heading of the second table comes from the file. The actual diff (also attached) shows more differences than the diff view.

weirddiff.png - Screenshot of diff view (83.8 KB) Sjoerd Langke, 2009-11-09 12:00

changeset_r28711.diff Magnifier - Unified diff of displayed change (6.17 KB) Sjoerd Langke, 2009-11-09 12:00

redmine-inline.png - Screenshot of inline diff view (39.3 KB) Sjoerd Langke, 2009-11-09 17:53

Associated revisions

Revision 3028
Added by Jean-Philippe Lang almost 12 years ago

Fixes diff parser for when lines starting with multiple dashes are removed (#4186).

History

#1 Updated by Thomas Pihl almost 12 years ago

You have selected to show diff "side by side".

What will it show if you select "inline" instead?

There might be some whitespaces handled differently in the view compared to the downloaded version.

#2 Updated by Sjoerd Langke almost 12 years ago

With inline view it is the same.

#3 Updated by Jean-Philippe Lang almost 12 years ago

  • Status changed from New to Closed
  • Target version set to 0.9.0
  • Affected version (unused) set to 0.8.6
  • Resolution set to Fixed
  • Affected version set to 0.8.6

Fixed in r3028.

#4 Updated by Sjoerd Langke almost 12 years ago

Thank you.

Also available in: Atom PDF