Project

General

Profile

Actions

Defect #43002

closed

RepositoriesSubversionControllerTest fails in 5.1-stable due to missing foo.js in test repository

Added by Go MAEDA 21 days ago. Updated 20 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
SCM
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

#42839 fixed a problem where files with a .js extension could not be downloaded from the repository browser. This fix was backported to both 6.0-stable and 5.1-stable branches. In 5.1-stable branch, the backport was applied in r23857.

However, the test included in this backport refers to a file named foo.js`, which was introduced in #39747 for Redmine 6.0. Since foo.js does not exist in the Subversion test repository for 5.1-stable, the following error occurs. . This problem was reported by Massimo Rossello (Massimo Rossello) in #42839#note-7:

Failure:
RepositoriesSubversionControllerTest#test_entry_should_return_text_plain_for_js_files [test/functional/repositories_subversion_controller_test.rb:376]:
Expected response to be a <2XX: success>, but was a <404: Not Found>

rails test test/functional/repositories_subversion_controller_test.rb:360

The attached patch fixes this issue by removing the test test_entry_should_return_text_plain_for_js_files, which refers to the missing foo.js file.

Because this test still runs in both the trunk and 6.0-stable branches, I believe that removing the test from `5.1-stable` is an appropriate solution.


Files


Related issues

Related to Redmine - Defect #42839: Downloading .js files from the repository browser fails with a 422 error due to ActionController::InvalidCrossOriginRequestClosedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA 20 days ago

  • Category changed from Code cleanup/refactoring to SCM
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix in r23885.

Actions #2

Updated by Go MAEDA 20 days ago

  • Related to Defect #42839: Downloading .js files from the repository browser fails with a 422 error due to ActionController::InvalidCrossOriginRequest added
Actions #3

Updated by Go MAEDA 20 days ago

  • Status changed from New to Closed
Actions

Also available in: Atom PDF