Project

General

Profile

Actions
Copy link

Patch #43125

closed

Remove redundant fixtures declaration from OauthProviderSystemTest

Added by Katsuya HIDAKA 1 day ago. Updated about 5 hours ago.

Status:
Closed
Priority:
Normal
Assignee:
Marius BĂLTEANU
Category:
Code cleanup/refactoring
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

This patch removes a redundant fixture declaration from the OauthProviderSystemTest class. The declaration was unnecessary because fixtures :all is already declared in ActiveSupport::TestCase.

diff --git a/test/system/oauth_provider_test.rb b/test/system/oauth_provider_test.rb
index 364ed4c944..df3f8fa7ed 100644
--- a/test/system/oauth_provider_test.rb
+++ b/test/system/oauth_provider_test.rb
@@ -6,12 +6,6 @@
 require 'puma'

 class OauthProviderSystemTest < ApplicationSystemTestCase
-  fixtures :projects, :users, :email_addresses, :roles, :members, :member_roles,
-           :trackers, :projects_trackers, :enabled_modules, :issue_statuses, :issues,
-           :enumerations, :custom_fields, :custom_values, :custom_fields_trackers,
-           :watchers, :journals, :journal_details, :versions,
-           :workflows
-
   test 'application creation and authorization' do
     #
     # admin creates the application, granting permissions and generating a uuid

I have verfied that all tests incuding system tests pass.
https://github.com/hidakatsuya/redmine/actions/runs/16900512596/job/47878975048

Related issues

Related to Redmine - Feature #24808: OAuth2 support for Redmine API Apps (OAuth2 Provider)ClosedMarius BĂLTEANU

Actions
Actions
Copy link
 #1

Updated by Marius BĂLTEANU about 6 hours ago

  • Related to Feature #24808: OAuth2 support for Redmine API Apps (OAuth2 Provider) added
Actions
Copy link
 #2

Updated by Marius BĂLTEANU about 6 hours ago

  • Status changed from New to Closed
  • Assignee set to Marius BĂLTEANU

Committed as part #24808, thanks!

Actions
Copy link
 #3

Updated by Katsuya HIDAKA about 5 hours ago

Thank you for your commit. It looks like a linting error was introduced.

Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body
https://github.com/redmine/redmine/actions/runs/16928424735/job/47968640367

Here is a patch to fix it:

diff --git a/test/system/oauth_provider_test.rb b/test/system/oauth_provider_test.rb
index aaef65c86..df3f8fa7e 100644
--- a/test/system/oauth_provider_test.rb
+++ b/test/system/oauth_provider_test.rb
@@ -6,7 +6,6 @@ require 'rack'
 require 'puma'

 class OauthProviderSystemTest < ApplicationSystemTestCase
-
   test 'application creation and authorization' do
     #
     # admin creates the application, granting permissions and generating a uuid
Actions
Copy link

Also available in: Atom PDF