Project

General

Profile

Actions
Copy link

Patch #43289

closed

Incorrect comments_count value in News fixture for news_001

Added by Go MAEDA about 2 months ago. Updated about 1 month ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Code cleanup/refactoring
Target version:
7.0.0
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In the test fixture news.yml, the news_001 record defines comments_count: 1, but there are actually two related `Comment` records for this news item. Since this is confusing when testing Redmine, the comments_count value should be updated to 2 to match the number of associated comments.

Files

Download all files
clipboard-202510041718-uic3x.png (90.2 KB) clipboard-202510041718-uic3x.png Go MAEDA, 2025-10-04 10:18
clipboard-202510041719-u7zsh.png (103 KB) clipboard-202510041719-u7zsh.png Go MAEDA, 2025-10-04 10:19
fix-news-comments_count.patch (1.1 KB) fix-news-comments_count.patch Go MAEDA, 2025-10-04 10:24
fix-news-comments_count-v2.patch (1.04 KB) fix-news-comments_count-v2.patch Go MAEDA, 2025-10-05 03:41
Actions
Copy link
 #1

Updated by Go MAEDA about 2 months ago

  • File fix-news-comments_count-v2.patch added

Updated the test to use assert_difference　instead of asserting specific count values.

Actions
Copy link
 #2

Updated by Go MAEDA about 2 months ago

  • File fix-news-comments_count-v2.patch added
  • File deleted (fix-news-comments_count-v2.patch)
Actions
Copy link
 #3

Updated by Go MAEDA about 2 months ago

Actions
Copy link
 #4

Updated by Go MAEDA about 2 months ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the fix in r24028.

Actions
Copy link
 #5

Updated by Go MAEDA about 1 month ago

  • Target version changed from Candidate for next major release to 7.0.0
Actions
Copy link

Also available in: Atom PDF