Project

General

Profile

Actions

Patch #43652

closed

Remove unused style for `td.username img.gravatar`

Added by Go MAEDA 1 day ago. Updated about 17 hours ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

This style rule was previously used for Gravatar icons in the "Login" column of the admin/users list.

In r21823, the admin/users list was rewritten to introduce the query system, and Gravatar icons were removed at that time. As a result, the td.username img.gravatar rule is no longer used and can be safely removed.

diff --git a/app/assets/stylesheets/application.css b/app/assets/stylesheets/application.css
index 14d462702..10e90fe71 100644
--- a/app/assets/stylesheets/application.css
+++ b/app/assets/stylesheets/application.css
@@ -1970,8 +1970,6 @@ div.avatar-with-child > .avatar:nth-child(2).group-avatar {

 h2 .avatar, h3 .avatar {margin-right: 4px;}
 h4 img.gravatar {margin: -2px 4px -4px 0;}
-/*# TODO: check where this rule is still used*/
-td.username img.gravatar {margin: 0 0.5em 0 0; vertical-align: top;}
 #activity dt .avatar {margin: 0 1em 0 0;}

 #activity dt, .journal {clear: left;}


Files

Actions #1

Updated by Go MAEDA about 17 hours ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch in r24286.

Actions

Also available in: Atom PDF