Project

General

Profile

Actions

Patch #43684

closed

Remove unused styles for `span.add_attachment a`

Added by Go MAEDA 24 days ago. Updated 20 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
-

Description

The CSS rule for span.add_attachment a, defined at source:tags/6.1.1/app/assets/stylesheets/application.css#L576, is no longer used and can be safely removed.

It was introduced in r9254 for "Add another file" link in the attachment form. However, the link was removed in r10977 and the CSS rule has not been used since then.

diff --git a/app/assets/stylesheets/application.css b/app/assets/stylesheets/application.css
index 0abf9e3e8..422853e8e 100644
--- a/app/assets/stylesheets/application.css
+++ b/app/assets/stylesheets/application.css
@@ -633,7 +633,6 @@ td.center {text-align:center;}
 span#watchers_inputs {overflow:auto; display:block;}
 span.search_for_watchers {display:block;}
 span.search_for_watchers, span.add_attachment {font-size:93%; line-height:2.5em;}
-span.add_attachment a {padding-left:16px; background: url(/bullet_add.png) no-repeat 0 50%; }

 input:disabled, select:disabled, textarea:disabled {
   cursor: not-allowed;

Related issues

Related to Redmine - Patch #43702: Remove unused CSS rulesClosedGo MAEDAActions
Actions #1

Updated by Go MAEDA 23 days ago

  • Subject changed from Remove unused style for `span.add_attachment a` to Remove unused styles for `span.add_attachment a`
  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the fix in r24331.

Actions #2

Updated by Go MAEDA 20 days ago

Actions #3

Updated by Go MAEDA 20 days ago

  • Target version deleted (7.0.0)

Since this is a very small change, it will be aggregated in the Changelog under the meta issue #43702.

Removing from the target version7.0.0.

Actions

Also available in: Atom PDF