Patch #4643

Allow on-the-fly creation on member addition

Added by Marcel Waldvogel over 12 years ago. Updated over 9 years ago.

Status:ClosedStart date:2010-01-24
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:LDAP
Target version:-

Description

In our setup, our users are in LDAP, with onthefly creation enabled.

The standard workflow for inviting a new member into a project is rather awkward:
  1. Send mail to invite the user with request to login once
  2. That user logs in
  3. Wait for that user's acknowledgement mail
  4. Add the user to the project
This patch allows the following simplified procedure:
  1. Add new user directly in the member screen to the project
  2. Notify the user

You now can enter a login name from any onthefly LDAP source in the settings/members search box, select a role, and click "add" to have everything happen at once. For larger group additions, you can even add multiple names separated by whitespace. This is IMHO the most straightforward way to add new users, although it might not be obvious to first-time users.

The code is not the nicest and user feedback is minimal, but it fulfills the purpose. Feel free to adapt it.

member-onthefly.patch Magnifier (9 Bytes) Marcel Waldvogel, 2010-01-24 00:15

member-onthefly-somewhat-more-elaborate-SMILE.patch Magnifier (4.5 KB) Marcel Waldvogel, 2010-01-25 00:54


Related issues

Related to Redmine - Patch #4755: Create and maintain groups from LDAP attributes New 2010-02-08

History

#1 Updated by Holger Just over 12 years ago

Your patch is also rather... minimal :)

#2 Updated by Marcel Waldvogel over 12 years ago

Holger Just wrote:

Your patch is also rather... minimal :)

Sure, especially after removing my logger events. Be aware that I am not a senior Rails expert (yet :-)).

To my defence, I basically do consider my patch to be in line with the member addition UI, whose error visualisation is minimal (just entering a name and not selecting a user or not selecting a role will not give any visual feedback. Therefore, I would not know how to integrate this function into the code.

However, if there you could give me concrete advice how to improve the code, I would be glad to try and implement it.

#3 Updated by Holger Just over 12 years ago

Marcel Waldvogel wrote:

However, if there you could give me concrete advice how to improve the code, I would be glad to try and implement it.

Well, I think the first step on improvement would be to upload the actual patch. Your attachment consists only of 9 random chars. Like I said: rather minimal :)

#4 Updated by Marcel Waldvogel over 12 years ago

Oh, I did not take the comment as serious as I should have. In fact, this was my submission for the Obfuscated Rails Coding Contest :-). Here's the real thing:

#5 Updated by Marcel Waldvogel over 12 years ago

This patch has been superseded by #4755 (nicer code and also LDAP group support)

#6 Updated by Marcel Waldvogel over 12 years ago

  • Status changed from New to Resolved

#7 Updated by Jan Niggemann (redmine.org team member) over 9 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF