Defect #5280

Issue lock_version not working

Added by Tim Coleman over 10 years ago. Updated over 10 years ago.

Status:ClosedStart date:2010-04-09
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-
Resolution:Fixed Affected version:

Description

I'm finding that on trunk the lock_version of the Issue model isn't being taken into account, meaning that different users can make conflicting changes to issues without any notice from redmine.

I've only had a cursory look at the source, but it looks like lock_version should perhaps be a safe attribute (see r3308), otherwise it never gets set from the request params.

Additionally (perhaps this should be a different bug?) once the lock_version is accepted as a safe attribute, the stale object exception handler in IssuesContoller::update attempts to read a non-existant variable 'attachments'. It looks like that variable was refactored away to the Issue model in r3545

Associated revisions

Revision 3663
Added by Jean-Philippe Lang over 10 years ago

Fixed: issue optimistic locking broken by r3308 (#5280).

History

#1 Updated by Jean-Philippe Lang over 10 years ago

  • Status changed from New to Closed
  • Resolution set to Fixed

All is fixed in r3663. Thanks for pointing it out.

#2 Updated by Tim Coleman over 10 years ago

Great :) Thanks for being so quick

Also available in: Atom PDF