Project

General

Profile

Actions

Defect #7846

closed

Headers (h1, etc.) containing backslash followed by a digit are not displayed correctly

Added by Etienne Massip about 13 years ago. Updated almost 13 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Text formatting
Target version:
Start date:
2011-03-12
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Wiki page titles containing backslashes followed by a digit are not rendered properly because of the way String.gsub handles specifically this sequence with Ruby 1.8 (1.9 changed this behavior).

From Ruby String.gsub doc :

However, the sequences \1, \2, and so on may be used to interpolate successive groups in the match.

I made a patch.


Files

Actions #1

Updated by Jean-Philippe Lang about 13 years ago

Would be nice to add a test to TextileFormatterTest.

Actions #2

Updated by Etienne Massip about 13 years ago

I'll do so.

Actions #3

Updated by Etienne Massip about 13 years ago

Here's the patch with test.

Actions #4

Updated by Etienne Massip about 13 years ago

  • File deleted (wiki_page_title_with_backslash_and_digit.patch)
Actions #5

Updated by Jean-Philippe Lang about 13 years ago

  • Status changed from New to Resolved
  • Target version changed from Candidate for next minor release to 1.1.3
  • Resolution set to Fixed

Patch applied in r5100, thanks. Just fixed the space before parenthesis in #assert_html_output.

Actions #6

Updated by Jean-Philippe Lang almost 13 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF