Project

General

Profile

Actions

Patch #812

closed

Include issue refs on closed issues

Added by John Goerzen about 16 years ago. Updated about 16 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
SCM
Target version:
-
Start date:
2008-03-08
Due date:
% Done:

0%

Estimated time:

Description

Consider a case where issue 5 exists in the issue database already and
is already marked closed. If you have a "closes" statement in your
changelog that references a bug that's already closed, no linkage will
be applied because of this:

next if issue.status.is_closed?

This patch moves the code that updates referenced_issues above that
test, so that it still will avoid a duplicate attempt to close the
issue, but nonetheless will add the reference to the issue.


Files

ref.diff (1.56 KB) ref.diff John Goerzen, 2008-03-08 02:59
Actions #1

Updated by Jean-Philippe Lang about 16 years ago

This code:

next if issue.status.is_closed?

will only prevent lines 87 to 92 to be executed.
A referenced and closed issue will be associated with the commit. I've made the test and it works as expected.

Did you experience a problem with this ?

Actions #2

Updated by John Goerzen about 16 years ago

  • Status changed from New to Closed

You're right. Further testing has showed that I was confused because the Resolved status wasn't a "closed" status by default. Sorry for the noise.

Actions

Also available in: Atom PDF