Patch #820
NoMethodError in SearchController
| Status: | Closed | Start date: | 2008-03-10 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | Search engine | |||
| Target version: | 0.7 |
Description
Submitting an invalid project id to a search results in a NoMethodError from a nil object.
You have a nil object when you didn't expect it!
The error occurred while evaluating nil.active?
app/controllers/application.rb:105:in `check_project_privacy'
app/controllers/search_controller.rb:41:in `index'This patch checks whether the project exists first, and a 404 page is displayed instead. Test included.
Associated revisions
Fixes #820: invalid project id causes a NoMethodError in SearchController (Angel Dobbs-Sciortino).
History
#1
Updated by Angel Sciortino over 10 years ago
Applies cleanly to r1212.
#2
Updated by Jean-Philippe Lang over 10 years ago
- Category set to Search engine
- Status changed from New to Closed
- Target version set to 0.7
Patch applied with slight changes in r1237 (used a before_filter instead).
Thanks