Project

General

Profile

Actions
Copy link

Patch #820

closed

NoMethodError in SearchController

Added by Angel Sciortino about 15 years ago. Updated about 15 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Search engine
Target version:
0.7
Start date:
2008-03-10
Due date:
% Done:

0%

Estimated time:

Description

Submitting an invalid project id to a search results in a NoMethodError from a nil object.

You have a nil object when you didn't expect it!
The error occurred while evaluating nil.active?

app/controllers/application.rb:105:in `check_project_privacy'
app/controllers/search_controller.rb:41:in `index'

This patch checks whether the project exists first, and a 404 page is displayed instead. Test included.

Files

fix_NoMethodError_in_SearchController.diff (1.85 KB) fix_NoMethodError_in_SearchController.diff Angel Sciortino, 2008-03-10 00:20
Actions
Copy link
 #1

Updated by Angel Sciortino about 15 years ago

Applies cleanly to r1212.

Actions
Copy link
 #2

Updated by Jean-Philippe Lang about 15 years ago

  • Category set to Search engine
  • Status changed from New to Closed
  • Target version set to 0.7

Patch applied with slight changes in r1237 (used a before_filter instead).
Thanks

Actions
Copy link

Also available in: Atom PDF