Project

General

Profile

Actions

Patch #8301

closed

queries/_filters.rhtml inefficient.

Added by ciaran jessup almost 13 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Issues
Target version:
-
Start date:
2011-05-05
Due date:
% Done:

0%

Estimated time:

Description

On my system ( fairly complex, ~30 projects, several hundred versions etc.) The issue list page is slow to load. Almost no time is reported in the DB, most of the time is spent in the view, most of which is spent rendering the filters.

This patch reduces some of that load by avoiding ( I think ) an un-neccessary sort of the filter options, I suspect the loop traversal could occur just once instead of twice.

Patch attached. For me this shaves ~33% of the render time off!


Files

sort_only_once.patch (1.48 KB) sort_only_once.patch ciaran jessup, 2011-05-05 17:37
Actions #1

Updated by Go MAEDA over 6 years ago

  • Status changed from New to Closed

The successor app/views/queries/_filters.html.erb uses JavaScript to collect available filters since r10162 and unnecessary query and sort was removed.

Thank you for your contribution.

Actions

Also available in: Atom PDF