Project

General

Profile

Actions

Defect #8458

closed

Subversion: Delete invalid repository fails using the libsvn plugin

Defect #8458: Subversion: Delete invalid repository fails using the libsvn plugin

Added by André Jonsson over 15 years ago. Updated over 15 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Toshi MARUYAMA
Category:
SCM
Target version:
-
Resolution:
Affected version:

Description

Only tested with svn repositories, using the libsvn plugin.

When an unreachable repository has been entered it is impossible to delete it. Apparently it requires the repository be valid and able to connect to be deleted.

For example, entering the repos url svn://localhost will cause delete to fail with the attached log message 1.

And entering a correct repos url but with incorrect login info fails similarly, with attached log message 2.


Files

logmessage1.txt (946 Bytes) logmessage1.txt log message 1 André Jonsson, 2011-05-29 12:50
logmessage2.txt (991 Bytes) logmessage2.txt log message 2 André Jonsson, 2011-05-29 12:50
git-scm-nil.diff (873 Bytes) git-scm-nil.diff Toshi MARUYAMA, 2011-05-30 02:43

Related issues 3 (2 open — 1 closed)

Related to Redmine - Defect #6713: Git: Not able to Resetting Redmine project respositoryNewToshi MARUYAMAActions
Related to Redmine - Defect #4725: Error displaying Project's Settings when repository configuredNewActions
Related to Redmine - Feature #1406: Browse through Git branchesClosedEric DavisActions

Updated by André Jonsson over 15 years ago Actions #1

For correctness I should probably mention that after changing the repos settings to something that is possible to connect with, delete works, of course.

Updated by Toshi MARUYAMA over 15 years ago Actions #2

  • Assignee set to Toshi MARUYAMA

Updated by Toshi MARUYAMA over 15 years ago Actions #3

Try this patch.

Updated by André Jonsson over 15 years ago Actions #4

Awesome!

However, I see that it modifies some generic part and a git-specific part (I'm not much familiar with Ruby nor the Redmine code base), but as far I've seen this problem is specific to SVN.

Of course, that doesn't exclude that this patch is the "right thing"... I'll give it a go later.

Updated by Toshi MARUYAMA over 15 years ago Actions #5

  • Target version set to 1.3.0

Updated by André Jonsson over 15 years ago Actions #6

I've tested the patch. Indeed it works!

However, I'm quite baffled as to why it works... considering it seemingly modified the behavior of managing git repositories.

Updated by André Jonsson over 15 years ago Actions #7

btw, sorry for the slow feedback; we had a long weekend over here and I was away a bit.

Updated by Toshi MARUYAMA over 15 years ago Actions #8

  • Subject changed from Delete invalid repository fails to Subversion: Delete invalid repository fails using the libsvn plugin
  • Target version deleted (1.3.0)

Updated by Toshi MARUYAMA over 15 years ago Actions #9

  • Status changed from New to Closed

Redmine subversion adapter#info returns nil if repository path is invalid.
source:tags/1.2.0/lib/redmine/scm/adapters/subversion_adapter.rb#L86

libsvn plugin adapter#info throws exception if repository path is invalid.
https://github.com/pplr/redmine-libsvn/blob/0662d754198723b6e8ad9c941d883fc5691b94f9/lib/redmine/scm/adapters/subversion_libsvn_adapter.rb#L87

This is plugin issue.

Actions

Also available in: PDF Atom