Feature #10362

Show images in repositories inline when clicking the 'View' link

Added by Hiroaki Nakamura over 5 years ago. Updated over 5 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:SCM
Target version:2.1.0
Resolution:

Description

[PATCH] Show images in repositories inline when you click...

Currently, when you click the "View" link for image files in repositories views,
image files are downloaded.
I would like image files to be displayed inline.

For your information, in issues views, when you click image file links,
image files are displayed inline.

So, not only it is more convenient but also it is more consistent with this change.
Please review this patch and include it if it is OK.

show_repositories_image_inline.patch Magnifier (708 Bytes) Hiroaki Nakamura, 2012-03-04 08:03

Associated revisions

Revision 9776
Added by Jean-Philippe Lang over 5 years ago

Show repository images inline when clicking 'View' (#10362).

History

#1 Updated by Steven Wong over 5 years ago

it seems a nice improvement. thanks.

#2 Updated by Etienne Massip over 5 years ago

  • Category set to SCM extra
  • Target version set to Candidate for next major release

I like the use of Redmine::MimeType.

Side note: maybe it could also be used in the places indicated by Toshi in #9638?

#3 Updated by Ivan Cenov over 5 years ago

I tested patch in trunk r9249.

View and Download links display the picture. While this is OK for View, Download should not display but download the picture.

#4 Updated by Jean-Philippe Lang over 5 years ago

  • Tracker changed from Patch to Feature
  • Subject changed from Show images in repositories inline when you click view links to Show images in repositories inline when clicking the 'View' link
  • Category changed from SCM extra to SCM
  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version changed from Candidate for next major release to 2.1.0

Patch changed to force then download when clicking "Download" + test added. Committed in r9776.

Also available in: Atom PDF