Defect #11118
closed
"Maximum file size" displayed on upload forms is incorrect
Added by Hubert B almost 12 years ago.
Updated almost 12 years ago.
Description
Hi there!
I just discovered a small issue: Setting "Maximum attachment size" in the Administrator's panel to 25600 kB causes a "Maximum file size" to be shown as 30 MB.
Steps to reproduce:
- Log in as administrator and set "Maximum attachment size" to 25600 kB
- Change to a project
- Go to the file tab
- Select "New file"
- Observe "Maximum file size" being displayed as 30 MB
- Go back to a project
- Select "New issue"
- Observe "Maximum size" being displayed as 30 MB
My system:
- Debian Squeeze
- PostgreSQL 8.4.11-0squeeze1
- Ruby 1.8.7.302-2squeeze1
- Rails 3.2.3
- Redmine 2.0.1
- Status changed from New to Confirmed
Reproduced with language set to English. Works fine with language set to French.
- Status changed from Confirmed to Resolved
- Target version set to 2.0.3
- Resolution set to Fixed
Fixed in r9782. It seems that Rails now uses the precision as the number precision instead of the decimal precision in 2.x.
- Subject changed from "Maximum file size" differs from "Maximum attachment size" to "Maximum file size" displayed on upload forms is incorrect
- Status changed from Resolved to Closed
- Status changed from Closed to Reopened
Jean-Philippe Lang wrote:
Etienne Massip wrote:
Please also have a look at RE: Unit for Maximum Attachment Size - KiB or kB.
You're right, reverted to KB in r9784. I personally dislike IEC prefixes.
Acttually I'm right about the inconsistency betweenthe prefix used in settings tkB for 1000 bytes) and the actual chech based on a Numeric#kilobytes of 1024 bytes, but was wrong about the revert: KB is indeed not a legal prefix. So, maybe we should either set kB back again and change the check to use number_human_format_size :prefix => :si or set the prefix in settings to 'KiB' which is arguabilly not very understandable yet?
- Status changed from Reopened to Closed
Rails' default is KB and I'm fine with it. According to Wikipedia the symbol for Kilobyte is kB or KB.
Also available in: Atom
PDF
Updated by 
Updated by