Feature #12787

Remove "Warning - iconv will be deprecated in the future, use String#encode instead."

Added by Terence Mill almost 5 years ago. Updated almost 5 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Code cleanup/refactoring
Target version:2.3.0
Resolution:Fixed

Description

/.rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.2.10/lib/active_support/dependencies.rb:251:in `block in require': iconv will be deprecated in the future, use String#encode instead.

Associated revisions

Revision 11176
Added by Jean-Philippe Lang almost 5 years ago

Removed useless require 'iconv' (#12787).

Revision 11177
Added by Jean-Philippe Lang almost 5 years ago

Don't use Iconv with ruby1.9 (#12787).

Revision 11178
Added by Jean-Philippe Lang almost 5 years ago

Encoding::InvalidByteSequenceError may be raised even if encoding is valid (#12787).

Revision 11179
Added by Toshi MARUYAMA almost 5 years ago

fix test failures (#12787)

Revision 11181
Added by Toshi MARUYAMA almost 5 years ago

use "UTF-16LE" instead of "UTF-16" on Ruby 1.9.2 due to test failure (#12787)

Revision 11440
Added by Jean-Philippe Lang almost 5 years ago

Don't use iconv with ruby1.9 (#12787).

History

#1 Updated by Jean-Philippe Lang almost 5 years ago

  • Subject changed from Remove Warning - iconv will be deprecated in the future, use String#encode instead. to Remove "Warning - iconv will be deprecated in the future, use String#encode instead."
  • Status changed from New to Closed
  • Target version set to 2.3.0
  • Resolution set to Fixed

Warning removed, thanks Toshi for the last fix.

#2 Updated by Etienne Massip almost 5 years ago

  • Status changed from Closed to Reopened

#3 Updated by Pavel Potcheptsov almost 5 years ago

I see it in Unicorn log:

/usr/local/rvm/gems/ruby-1.9.3-p327/gems/activesupport-3.2.11/lib/active_support/dependencies.rb:251:in `block in require': iconv will be deprecated in the future, use String#encode instead.

Environment:
  Redmine version                          2.2.2.stable.11244
  Ruby version                             1.9.3 (i686-linux)
  Rails version                            3.2.11
  Environment                              production
  Database adapter                         Mysql2

#4 Updated by Etienne Massip almost 5 years ago

Pavel Potcheptsov wrote:

I see it in Unicorn log:
[...]
[...]

Because it's not fixed with 2.2.2.stable, it will be for future version 2.3.0.

#5 Updated by Daniel Felix almost 5 years ago

  • Status changed from Reopened to Closed

I close it again. Etienne is right.

Just ignore it until upgrade. :-)

#6 Updated by Etienne Massip almost 5 years ago

  • Status changed from Closed to New

Should not have been closed, #note-2 is still true (and applicable to Trac importer).

#7 Updated by Jean-Philippe Lang almost 5 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

The rake tasks should be fixed in r11440.

Also available in: Atom PDF