Patch #13774

Show warning if CSV-Export exceeds limit

Added by Daniel Felix almost 5 years ago. Updated about 4 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Issues
Target version:2.5.0

Description

Hi there,

Filou Centrinov has reported a feature request in #13770. This patch aims to fix this.

Best regards,
Daniel

patch_warning_on_csv_export.diff Magnifier - Patch - Version 1 (3.12 KB) Daniel Felix, 2013-04-15 17:10

Screenshot.png - Screenshot after applying patch. (12.4 KB) Daniel Felix, 2013-04-15 17:10

patch_warning_on_csv_export_v2.diff Magnifier - Patch - Version 2 (3.49 KB) Daniel Felix, 2013-04-16 09:19


Related issues

Related to Redmine - Feature #13770: Show warning, when exported issues exceed the limit Closed

History

#1 Updated by Filou Centrinov almost 5 years ago

Three translation suggestions:
1st: EN: Export contains only %{export} of %{total} issues.
2nd: EN: Export contains only the first %{export} of %{total} issues.
3rd: EN: Export limit is {X}.

Also the pdf export needs a warning. I know, there is no dialog by default.

#2 Updated by Filou Centrinov almost 5 years ago

I think like this it would be more simple and logical:

  <% if @issue_count > @csv_limit %>
  <div class="flash warning">
    <%= l(:warning_export_limit, :export => @csv_limit, :total => @issue_count) %>
  </div>
  <% end %>

#3 Updated by Daniel Felix almost 5 years ago

Hi Filou,

your right the condition could be changed in this order. Well the result will be the same. :-)
I changed this in the patch.

In addition, I removed the .min. I added it in the first version (not uploaded here) to always display the count of the exported issues.

I changed the size of the modalbox and changed the translation to your suggestion nr. 1 in note 1.

If anyone has translations for this in his language, please provide them. I'll include them in the patch.

Best regards,
Daniel

#4 Updated by Daniel Felix almost 5 years ago

Any news on this? Is this patch okay?

#5 Updated by Jean-Baptiste Barth almost 5 years ago

  • Assignee set to Jean-Baptiste Barth

Seems ok at first sight, but needs a test or two so we won't break it inadvertently in a future release. I assign the issue to myself, I'll test it and write some tests tomorrow (except if you want to do so Daniel, would be great ;-))

Just one thing though, I'm always reluctant to add new locale keys (locale maintenance is a tiny nightmare). Isn't it possible to use the already existing setting_issues_export_limit ?

#6 Updated by Jean-Philippe Lang about 4 years ago

  • Subject changed from Show warning if CSV-Export exceeds limits. to Show warning if CSV-Export exceeds limit
  • Status changed from New to Closed
  • Assignee changed from Jean-Baptiste Barth to Jean-Philippe Lang
  • Target version set to 2.5.0

Feature added in r12663. I used the existing i18n string and added some tests.

Also available in: Atom PDF