Defect #14737: Gantt, completed % truncated instead of rounded - Redmine

Custom queries

Documentation issues
Open defects
Open features
Patch queue
Plugin issues
Translation patches

Actions

Copy link

Defect #14737

closed

Gantt, completed % truncated instead of rounded

Added by Jérôme BATAILLE over 10 years ago. Updated almost 10 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Category:

Gantt

Target version:

2.6.0

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

Files

Download all files

RM_14737_gantt_completed_pourcent_truncated.diff (834 Bytes) RM_14737_gantt_completed_pourcent_truncated.diff		Jérôme BATAILLE, 2013-08-21 16:23
RM_14737_gantt_completed_pourcent_truncated.diff (778 Bytes) RM_14737_gantt_completed_pourcent_truncated.diff		Jérôme BATAILLE, 2013-08-22 15:29
edit.png (6 KB) edit.png		Toshi MARUYAMA, 2014-05-14 13:45
view.png (5.79 KB) view.png		Toshi MARUYAMA, 2014-05-14 13:45

Related issues

Has duplicate Redmine - Feature #13442: Gantt : rounding error for version completed percent

Closed

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Jérôme BATAILLE over 10 years ago

File RM_14737_gantt_completed_pourcent_truncated.diff RM_14737_gantt_completed_pourcent_truncated.diff added

Here is a patch

Actions

Copy link

Updated by Daniel Felix over 10 years ago

+1 to the patch.
But English comments would be better. ;-)

Actions

Copy link

Updated by Jérôme BATAILLE over 10 years ago

File RM_14737_gantt_completed_pourcent_truncated.diff RM_14737_gantt_completed_pourcent_truncated.diff added

Sorry :-)

Actions

Copy link

Updated by Daniel Felix over 10 years ago

Np. Looks better. :-)

Actions

Copy link

Updated by Jérôme BATAILLE almost 10 years ago

Any chance that this very simple patch could be integrated to the core ?

Actions

Copy link

Updated by Toshi MARUYAMA almost 10 years ago

File edit.png edit.png added
File view.png view.png added

This problem is not only pdf but also web form.

diff --git a/app/views/issues/_attributes.html.erb b/app/views/issues/_attributes.html.erb
--- a/app/views/issues/_attributes.html.erb
+++ b/app/views/issues/_attributes.html.erb
@@ -63,7 +63,7 @@
 <% end %>

 <% if @issue.safe_attribute? 'estimated_hours' %>
-<p><%= f.text_field :estimated_hours, :size => 3, :disabled => !@issue.leaf?, :required => @issue.required_attribute?('estimated_hours') %> <%= l(:field_hours) %></p>
+<p><%= f.text_field :estimated_hours, :size => 10, :disabled => !@issue.leaf?, :required => @issue.required_attribute?('estimated_hours') %> <%= l(:field_hours) %></p>
 <% end %>

 <% if @issue.safe_attribute?('done_ratio') && @issue.leaf? && Issue.use_field_for_done_ratio? %>

Actions

Copy link

Updated by Jérôme BATAILLE almost 10 years ago

Hi Toshi,

You are talking about estimated_hours, do you mean that this is linked to done_ratio ?
The only place I have found this issue is in the Gantt, on the versions display percent is not truncated.

Actions

Copy link

Updated by Jérôme BATAILLE almost 10 years ago

Duplicated by #13442

Actions

Copy link

Updated by Toshi MARUYAMA almost 10 years ago

Jérôme BATAILLE wrote:

Hi Toshi,

You are talking about estimated_hours, do you mean that this is linked to done_ratio ?
The only place I have found this issue is in the Gantt, on the versions display percent is not truncated.

Sorry, I confused with #12510#note-15.

Actions

Copy link

#10