Defect #16564

Repository identifiers can be reserved words

Added by Felix Schäfer over 4 years ago. Updated about 4 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:SCM
Target version:2.5.2
Resolution:Fixed Affected version:2.5.1

Description

A client of Planio has created a repository with the identifier statistics and was unable to access that repository via the web UI. While investigating this issue, we discovered that the reserved words list for repository identifiers (source:/tags/2.5.1/app/models/repository.rb#L43) is incomplete (browse and others are missing) or wrong (stats should be statistics, show is double).

16564.diff Magnifier (950 Bytes) Felix Schäfer, 2014-04-08 11:33

Associated revisions

Revision 13127
Added by Jean-Philippe Lang about 4 years ago

Repository identifiers can be reserved words (#16564).

Patch by Felix Schäfer.

History

#1 Updated by Felix Schäfer over 4 years ago

The attached patch fixes this and has a list of reserved words as per rake routes | grep repository which should be complete. This doesn't handle possibly existing repos with those identifiers though.

#2 Updated by Jan from Planio www.plan.io over 4 years ago

  • Target version set to Candidate for next minor release

#3 Updated by Jean-Philippe Lang about 4 years ago

  • Category set to SCM
  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version changed from Candidate for next minor release to 2.5.2
  • Resolution set to Fixed

Committed in r13127, thanks.

#4 Updated by Jean-Philippe Lang about 4 years ago

  • Status changed from Resolved to Closed

Merged.

Also available in: Atom PDF