Defect #16989

Inline images in email does not appear when thumbnail macro is used.

Added by Bahri Yardim over 4 years ago. Updated over 4 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Email notifications
Target version:2.5.2
Resolution:Fixed Affected version:

Description

Redmine v2.5.1

When using

{{thumbnail(filename.png)}}
in a comment, the email sent to notify related users does not show the image. The <img> source starts with /attachments.
This is because relative url is used in thumbnail macro when processing the text.

To fix this, we should use the url_for argument :only_path => false, so that the generated urls are absolute.

The fix is in the patch and we are using it confidently in our system.


Related issues

Related to Redmine - Feature #2770: Display of inline attached images in email notification Reopened 2009-02-18

Associated revisions

Revision 13218
Added by Jean-Philippe Lang over 4 years ago

Include host in macro generated thumbnails urls (#16989).

History

#1 Updated by Go MAEDA over 4 years ago

Confirmed the problem with Redmine 2.5.1 and this patch addresses the problem.

#2 Updated by Toshi MARUYAMA over 4 years ago

  • Target version set to 2.5.2

#3 Updated by Go MAEDA over 4 years ago

Related to #2770.

The patch attached on this issue cannot display images on non-public projects.

#4 Updated by Toshi MARUYAMA over 4 years ago

  • Tracker changed from Patch to Defect

#5 Updated by Toshi MARUYAMA over 4 years ago

  • Related to Feature #2770: Display of inline attached images in email notification added

#6 Updated by Jean-Philippe Lang over 4 years ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Fixed in r13218, urls now include host name.

#7 Updated by Jean-Philippe Lang over 4 years ago

  • Status changed from Resolved to Closed

Merged.

Also available in: Atom PDF