Project

General

Profile

Actions

Patch #18134

open

Issues with svn:mergeinfo property values and r13443 rails-4.1 rebase.

Added by Mischa The Evil over 9 years ago. Updated over 9 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

After some Redmine core SCM log reviewing I noticed several issues:
  1. related to svn:mergeinfo properties:
    1. [rails-4.1 branch] r13443 rebase of rails-4.1 branch included rails-4.1 backport commits to trunk1 (in svn:mergeinfo only obviously): need to reverse-merge them for svn:mergeinfo
    2. [rails-4.1 branch] contains four commits merged from trunk2: this is not reflected in the respective svn:mergeinfo property
    3. [trunk] three commits were backported from rails-4.1 branch to trunk3: this is not reflected in the respective svn:mergeinfo property
    4. [2.6-stable branch] contains one commit merged from trunk (r13439): this is not reflected in the respective svn:mergeinfo property
  2. related to the r13443 rails-4.1 rebase:
    1. [rails-4.1 branch] r13443 rebase is missing commits from trunk4 ((start rails-4.1)..(start rebase)): still needs to be merged

So I checked out Redmine svn source and started fixing them one after another.

The first four are changes to the svn:mergeinfo values only (svn merge ... --record-only) and the last is a complete merge (thus with svn:mergeinfo property update) of fourteen commits where two files5 had some simple conflicts to be solved manually:
  • 1. reverse-merge-backport-commits-on-trunk_against_rails-4.1_at_r13451.patch: view details...
  • 2. merge-merged-in-41-from-trunk_to_rails-4.1_at_r13451.patch: view details...
  • 3. merge-backported-in-trunk-from-41_to_trunk_at_r13451.patch: view details...
  • 4. merge-merged-in-2.6-stable-from-trunk_to_2.6-stable_at_r13451.patch: view details...
  • 5. merge-missing-in-41-from-trunk_to_rails-4.1_at_r13451.patch: view details...
If these changes are applied then:
  • rails-4.1 branch contains all commits on trunk between the creation of the branch upto r13439 (fully rebased)
  • svn:merginfo property was already introduced around 2.4-stable and custom_fields branch
  • svn:merginfo property is started being reliably used with 2.6-stable (last 2.x?)
  • svn:merginfo property is having full history of rails-4.1 and current trunk
  • svn:merginfo property is having full history of and is reliably used with new major 3.0-stable and up

All the patches are taken against a checkout of the respective branches at r13451. If more information is need, please let me know. I have a bunch of notes taken during the inspection, which I could attach if needed as well.
I hope this is of any use...

Regards,

Mischa.

1 r13407 and r13408

2 r13302, r13306, r13311 and r13332

3 r13296, r13313 and r13315

4 r13284, r13285, r13287, r13299, r13303, r13322, r13323, r13324, r13325, r13326, r13327, r13329, r13330 and r13331

5 config/locales/de.yml and Gemfile


Files


Related issues

Related to Redmine - Defect #18174: Rails-4.1 branch merge into trunk (r13482) reverts trunk commitsClosedJean-Philippe Lang

Actions
Actions

Also available in: Atom PDF