Redmine

An enhancement to #17993

Hi, is it possible to examine this patch ?

second and third sort are very useful, and they can not be explicitly showed with css without this patch.

This adds the same tag on the second and third sort on the table tag, but in fact it's not the more important part.

I omitted the way to explicit / change the second and third link :

          def sort_link(column, caption, default_order)
            css, order = nil, default_order

            if column.to_s == @sort_criteria.first_key
              if @sort_criteria.first_asc?
                css = 'sort asc'
                order = 'desc'
              else
                css = 'sort desc'
                order = 'asc'
              end
            end

            # Smile specific : #149968 Display sort icons for second and third sort column
            # Smile specific : second sort column
            if @sort_criteria.size >= 2 && column.to_s == @sort_criteria.second_key
              if @sort_criteria.second_asc?
                css = 'sort2 asc'
              else
                css = 'sort2 desc'
              end
            end

            # Smile specific : third sort column
            if @sort_criteria.size >= 3 && column.to_s == @sort_criteria.third_key
              if @sort_criteria.third_asc?
                css = 'sort3 asc'
              else
                css = 'sort3 desc'
              end
            end
            # END -- Smile specific : #149968 Display sort icons for second and third sort column
            caption = column.to_s.humanize unless caption

            sort_options = { :sort => @sort_criteria.add(column.to_s, order).to_param }
            url_options = params.merge(sort_options)

             # Add project_id to url_options
            url_options = url_options.merge(:project_id => params[:project_id]) if params.has_key?(:project_id)

            # Smile specific : #149968 Display sort icons for second and third sort column
            # Smile specific : Sort link on a second line
            link_to_content_update(h(caption), url_options) +
              '<br/>'.html_safe +
              link_to_content_update('&nbsp;&nbsp;&nbsp;&nbsp;'.html_safe, url_options, :class => css)
            # END -- Smile specific : #149968 Display sort icons for second and third sort column
          end

Sorry for the Smile specific tags and for the missing tests.

As you can see the sort links are put on a second line of the th cells.

By the way there no mean to remove a sort.

Hi,

This issue can be closed, I have developed a plugin for this feature :
http://www.redmine.org/plugins/redmine_smile_three_sortings