Patch #2025

Pluggable wiki formatter

Added by Yuki Sonoda about 9 years ago. Updated almost 9 years ago.

Status:ClosedStart date:2008-10-12
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Wiki
Target version:0.8

Description

This patch makes wiki formatting pluggable.

You can add a new wiki formatting as a plugin. For example, I wrote RD plugin. This provides redmine with Ruby Document Format, which is the format Ruby Issue Tracking System uses.

textile plugin

In the patch [[make-wiki-formatters-pluggable.patch]], textile formatter is still embedded in Redmine.
But it is possible to extract the embedded textile formatting from redmine. [[extract-textile-formatting-as-a-plugin.patch]] does this. Perhaps, this patch needs git-am(1) because it renames some files.

make-wiki-formatters-pluggable.patch Magnifier - makes wiki formatting pluggable (31.8 KB) Yuki Sonoda, 2008-10-12 05:19

extract-textile-formatting-as-a-plugin.patch Magnifier - extracts textile formatter as a plugin (236 KB) Yuki Sonoda, 2008-10-12 05:19


Related issues

Related to Redmine - Feature #2166: Extend Textile syntax via plugin Closed 2008-11-12

Associated revisions

Revision 1955
Added by Jean-Philippe Lang almost 9 years ago

Makes wiki text formatter pluggable.
Original patch #2025 by Yuki Sonoda slightly edited.

History

#1 Updated by Yuki Sonoda about 9 years ago

Oops, URL for my RD plugin was wrong. It is http://github.com/yugui/redmine_rd_formatter.

#2 Updated by James Turnbull about 9 years ago

+1.

#3 Updated by Jean-Philippe Lang almost 9 years ago

  • Status changed from New to Closed
  • Target version set to 0.8

This nice feature which is committed in r1955 with minor changes.

One thing concerning your RD plugin:
I removed the jstoolbar stylesheet include tag from the base layout so that plugins can use other libraries to render the toolbar. So, you'll have to add it in #heads_for_wiki_formatter. It would look like this:

def heads_for_wiki_formatter
  stylesheet_link_tag('jstoolbar') +
  stylesheet_link_tag('rd', :plugin => 'redmine_rd_formatter')
end

Your plugin was tested OK with this change.

Concerning your second patch, I prefer to keep the Textile formatter bundled in the app because I don't want to rely on Engines' mirror files mechanism for such a core functionality.

Thanks.

#4 Updated by Yuki Sonoda almost 9 years ago

Thank you, Jean-Phillipe. I committed the change you suggested into http://github.com/yugui/redmine_rd_formatter/tree/master.

And I think this plugin can show the best example of wiki formatter implementation for plugin developers. Could you add the plugin to http://www.redmine.org/wiki/redmine/Plugins ?

#5 Updated by Jean-Philippe Lang almost 9 years ago

Indeed, a link to your plugin was added to the plugin list.

Also available in: Atom PDF