Patch #20298

"div" tag around revision details

Added by Go MAEDA about 3 years ago. Updated about 3 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:SCM
Target version:3.2.0

Description

Please add div element around revision details on RepositoriesController#revision page.

This change make possible to style revision details. Please see the following example.

styling-example.png (77.5 KB) Go MAEDA, 2015-07-12 13:18

div-around-revision-details.diff Magnifier (2.45 KB) Go MAEDA, 2015-07-12 13:20

Associated revisions

Revision 14482
Added by Toshi MARUYAMA about 3 years ago

"div" tag around revision details (#20298)

Contributed by Go MAEDA.

Revision 14483
Added by Toshi MARUYAMA about 3 years ago

adjust source indents (#20298)

History

#1 Updated by Mischa The Evil about 3 years ago

Go MAEDA wrote:

Please add div element around revision details on RepositoriesController#revision page.

Good idea, but looking at your patch I'd propose to keep the indentation of the revision details as it is (keeps history cleaner in my opinion). Just my 2 cents...

#2 Updated by Toshi MARUYAMA about 3 years ago

  • Target version set to 3.2.0

#3 Updated by Toshi MARUYAMA about 3 years ago

  • Subject changed from <div> around revision details to "div" tag around revision details
  • Status changed from New to Closed

Committed in trunk r14482 and r14483, thanks.

Also available in: Atom PDF