Defect #20677

Custom fields with multiple values required by worklow can be blank

Added by Pavel Rosický about 3 years ago. Updated almost 3 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Issues workflow
Target version:2.6.8
Resolution:Fixed Affected version:

Description

How to simulate:
1/ create new cf type list, non-required, select multiple values
2/ set cf as required in workflow
3/ update issue (cf is marked with * as required)
4/ issue will be saved without an error, even if you don't select any value

How it should work?
Validation error should be shown, because the custom field is required.

Fix & Test included

issues_controller_test.rb.patch Magnifier (10.2 KB) Pavel Rosický, 2015-09-04 23:49

issue.rb.patch Magnifier (522 Bytes) Pavel Rosický, 2015-09-04 23:49

Associated revisions

Revision 14670
Added by Jean-Philippe Lang about 3 years ago

List custom fields with multiple values set as required by workflow can be blank (#20677).

Patch by Pavel Rosický.

History

#1 Updated by Pavel Rosický about 3 years ago

Tested on master & stable 3.1.0

Environment:
Redmine version 3.1.0.devel.14542
Ruby version 2.1.5-p273 (2014-11-13) [i386-mingw32]
Rails version 4.2.4
Environment production
Database adapter Mysql2
SCM:
Subversion 1.8.13
Filesystem
Redmine plugins:
no plugin installed

#2 Updated by Toshi MARUYAMA about 3 years ago

  • Target version set to 3.2.0

#3 Updated by Jean-Philippe Lang about 3 years ago

  • Tracker changed from Patch to Defect
  • Subject changed from Workflow is ignored on custom fields with multiple values to Custom fields with multiple values required by worklow can be blank
  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Target version changed from 3.2.0 to 2.6.8

Fix applied in r14670, thanks.

#4 Updated by Jean-Philippe Lang almost 3 years ago

  • Status changed from Resolved to Closed
  • Resolution set to Fixed

Also available in: Atom PDF