Patch #21137

Rescue network level errors with LDAP auth

Added by Holger Just about 2 years ago. Updated about 2 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:LDAP
Target version:3.2.0

Description

Right now, only a small number of possible error cases is rescue inside the AuthSourceLdap model are rescued, namely errors happening on the LDAP protocol itself. This results in plain (and not really helpful) 500 errors on login for many common transient network errors, including an unstable connection between the app and the LDAP server, TLS certificate issues, DNS issues, changed firewalls...

The attached patch against current trunk at r14793 provides a list of exceptions that are explicitly rescued to show a nice error message to the user instead of just failing with an HTTP 500. This should result in much more pleasant experience for people using LDAP auth.

This patch was extracted from Planio.

0001-Rescue-network-level-errors-with-LDAP-auth-to-avoid-.patch Magnifier (1.76 KB) Holger Just, 2015-11-03 11:06

Associated revisions

Revision 14808
Added by Jean-Philippe Lang about 2 years ago

Rescue network level errors with LDAP auth (#21137).

Patch by Holger Just.

History

#1 Updated by Toshi MARUYAMA about 2 years ago

  • Target version set to 3.2.0

#2 Updated by Jean-Philippe Lang about 2 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Thanks.

Also available in: Atom PDF